Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 1ES-hosted agent for CentOS-7 in end-to-end tests #5284

Merged
merged 11 commits into from
Sep 3, 2021
Merged

Use 1ES-hosted agent for CentOS-7 in end-to-end tests #5284

merged 11 commits into from
Sep 3, 2021

Conversation

damonbarry
Copy link
Member

@damonbarry damonbarry commented Jul 24, 2021 •
edited

1ES-hosted pools now support CentOS-7 agents, so this change migrates the CentOS job in our end-to-end test pipeline to use a 1ES-hosted agent.

I confirmed that the job runs (and passes) on the expected agent in the end-to-end test pipeline.

@damonbarry damonbarry marked this pull request as ready for review September 3, 2021 00:14
nlcamp
nlcamp approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@nlcamp nlcamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was wondering why the change from using lsb_release to /etc/os-release wasn't needed but I checked and that change is already in the 1.1 branch.

@kodiakhq kodiakhq bot merged commit 1b6a85c into Azure:release/1.1 Sep 3, 2021
@damonbarry damonbarry deleted the centos-1.1 branch September 3, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlcamp nlcamp nlcamp approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@damonbarry @nlcamp