using pooled buffers has its own switch instread of 'optimizeForPerformance' #5358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,6 +79,7 @@ public void Register(ContainerBuilder builder) | |||
| }); | |||
|
|
|||
| bool optimizeForPerformance = this.configuration.GetValue("OptimizeForPerformance", true); | |||
| bool usePooledBuffers = this.configuration.GetValue("UsePooledBuffers", false); | |||
There was a problem hiding this comment.
Can we make this part of MqttSettings - https://github.com/Azure/iotedge/blob/master/edge-hub/core/src/Microsoft.Azure.Devices.Edge.Hub.Service/appsettings_hub.json#L2
So something like - mqttSettings__UseBufferPooling or mqttSettings__UsePooledBuffers
varunpuranik
approved these changes
Aug 12, 2021
and-rewsmith
pushed a commit
to and-rewsmith/iotedge
that referenced
this pull request
Aug 17, 2021
…rmance' (Azure#5358) OptimizeForPerformance affects other things and we want to be able to control pooled/unpooled buffers separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OptimizeForPerformance affects other things and we want to be able to control pooled/unpooled buffers separately