Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 1.1.5 #5442

Merged
merged 2 commits into from
Sep 1, 2021
Merged

fix 1.1.5 #5442

merged 2 commits into from
Sep 1, 2021

Conversation

huguesBouvier
Copy link
Contributor

@huguesBouvier huguesBouvier commented Aug 31, 2021

docker API on windows is checking if socket exists during container creation. Since sockets are created when starting a container (hence after create) the modules are never deployed.

We suspect the issue was not found during testing because of the order of the tests (no proof but it is a very likely scenario).

  1. First the old edgeAgent image was used for testing. In this case the create container would work because the legacy workload socket is created from the start. The in the sub-sequent create, the module socket would get created.
  2. Then I would test with the new image, since the previous test did create the sockets, create would not complain.

Test:
Same test on windows 2019 and linux.
Verified windows 10 boots.

Tested with the new image from the beginning and verified that sockets are created.
Tested with legacy image and verified that sockets are created and are not used.
Tried stopping a module and checked listener would be stopped.
Tried removing a module with and without stopping the module first.

@huguesBouvier huguesBouvier marked this pull request as ready for review August 31, 2021 23:29
edgelet/iotedged/src/workload_manager.rs Outdated Show resolved Hide resolved
edgelet/edgelet-docker/src/runtime.rs Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 382cf77 into Azure:release/1.1 Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants