Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker API on windows is checking if socket exists during container creation. Since sockets are created when starting a container (hence after create) the modules are never deployed.
We suspect the issue was not found during testing because of the order of the tests (no proof but it is a very likely scenario).
Test:
Same test on windows 2019 and linux.
Verified windows 10 boots.
Tested with the new image from the beginning and verified that sockets are created.
Tested with legacy image and verified that sockets are created and are not used.
Tried stopping a module and checked listener would be stopped.
Tried removing a module with and without stopping the module first.