Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate images-release pipeline to use 1es agents #5459

Merged

Conversation

nlcamp
Copy link
Contributor

@nlcamp nlcamp commented Sep 3, 2021

This only affects the Windows job because the Linux jobs use Microsoft hosted agents.

@nlcamp nlcamp changed the base branch from master to release/1.1 September 3, 2021 14:44
@nlcamp
Copy link
Contributor Author

nlcamp commented Sep 7, 2021

@nlcamp nlcamp marked this pull request as ready for review September 7, 2021 23:22
- Build-Image -equals true
- win-rs5
- DotNetFramework
- ImageOverride -equals agent-aziotedge-winserver-2019dc-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Windows Enterprise LST instead of Windows Server.
agent-aziotedge-winserver-2019dc-build -> agent-aziotedge-win10-entn2019-build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that image initially but the build failed because it did not have Java installed on it. Here's the pipeline run from that attempt: https://msazure.visualstudio.com/One/_build/results?buildId=46366280&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=16be6190-c20b-50b6-8210-aa45e5159981

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows Server 2019 is locked to Windows 10.0.17763, just like Windows 10 LTS. agent-aziotedge-winserver-2019dc-build is the right image to use.

Copy link
Member

@damonbarry damonbarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note we can migrate the MS-hosted agents over to 1ES-hosted as well, and it will give use better response times (we won't be competing with the rest of the org for position in the queue). But the priority right now is removing the maintenance burden of custom agents.

@kodiakhq kodiakhq bot merged commit 1d3086e into Azure:release/1.1 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants