Remove Metric Collector module from publishing through Image release pipeline #5487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - The Metric Collector module is independently versioned; hence, it gets its own release pipeline instead of being bundle release in the Image release pipeline.
Context:
In the beginning, we use the image release pipeline to build the Metric Collector module. Since the module has become publicly available
1.0. We decided it's best to have the module be versioned independently from the rest of the image modules. The Metric Collector module since has its own pipeline for the release. (builds/misc/metrics-collector-images-release.yaml)Fix:
Remove Metric Collector module from publishing through Image release pipeline