Disable flaky CI and E2E tests #5502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimanch
reviewed
Sep 14, 2021
| @@ -29,7 +29,7 @@ public class RuntimeInfoProviderTest | |||
| static readonly IEntityStore<string, ModuleState> RestartStateStore = new Mock<IEntityStore<string, ModuleState>>().Object; | |||
| static readonly IRestartPolicyManager RestartManager = new Mock<IRestartPolicyManager>().Object; | |||
|
|
|||
| [Integration] | |||
| [Integration(Skip = "Flaky")] | |||
There was a problem hiding this comment.
nit : Can we provide reasoning in comments as to what component/method call is flaky?
There was a problem hiding this comment.
I am going to make PBIs with some contextual info. For most of these I don't even have much context other than sometimes it fails and it is a hard to pin down error. Right now I am prioritizing getting all the tests disabled so our pipelines are green. Then will circle back and organize the information.
damonbarry
approved these changes
Sep 14, 2021
yophilav
reviewed
Sep 14, 2021
nimanch
approved these changes
Sep 14, 2021
|
Discussed with Bear and he is helping to log work items after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are flaky so disabling. Some of these are redundant given coverage in other areas. So we can honestly delete them when needed. (Thinking the
RemovePropertySuccessandSendMessageBatchTesttests)