Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re enable some flaky tests #5587

Merged
merged 5 commits into from
Oct 1, 2021
Merged

Conversation

lfitchett
Copy link
Contributor

@lfitchett lfitchett commented Sep 27, 2021

I have run these tests over 20 times, some with all tests enabled. While some of the other flaky tests failed, these passed every time.

@lfitchett lfitchett marked this pull request as ready for review September 27, 2021 17:20
@lfitchett
Copy link
Contributor Author

Note "FrequentTwinPullsOnConnectionAreThrottledAsync " is failing in the checkin build, but only in the codecov run? Not sure why that is.

@@ -341,7 +341,7 @@ static async Task<Device> CreateEdgeDeviceWithCondition(string edgeDeviceId, Reg
}

[Integration]
[Fact(Skip = "Flaky")]
[Fact]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we talked about that one. It is not flaky, but long running. I thought that we were going to change that to pull frequently, instead just pausing for 7 min?

@lfitchett
Copy link
Contributor Author

I kept EdgeAgentConnectionConfigurationTest skipped for now. I have another branch where I'm trying to remove the wait, but its causing unexpected errors. Since this test is mostly just testing hub functionality, I don't think its a priority to enable it.

@vadim-kovalyov
Copy link
Contributor

I kept EdgeAgentConnectionConfigurationTest skipped for now. I have another branch where I'm trying to remove the wait, but its causing unexpected errors. Since this test is mostly just testing hub functionality, I don't think its a priority to enable it.

Sounds good, as long as we keep the work item in ADO open for that.

@kodiakhq kodiakhq bot merged commit 805ce3e into Azure:release/1.1 Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants