-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re enable some flaky tests #5587
Conversation
Note "FrequentTwinPullsOnConnectionAreThrottledAsync " is failing in the checkin build, but only in the codecov run? Not sure why that is. |
@@ -341,7 +341,7 @@ static async Task<Device> CreateEdgeDeviceWithCondition(string edgeDeviceId, Reg | |||
} | |||
|
|||
[Integration] | |||
[Fact(Skip = "Flaky")] | |||
[Fact] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we talked about that one. It is not flaky, but long running. I thought that we were going to change that to pull frequently, instead just pausing for 7 min?
I kept EdgeAgentConnectionConfigurationTest skipped for now. I have another branch where I'm trying to remove the wait, but its causing unexpected errors. Since this test is mostly just testing hub functionality, I don't think its a priority to enable it. |
Sounds good, as long as we keep the work item in ADO open for that. |
I have run these tests over 20 times, some with all tests enabled. While some of the other flaky tests failed, these passed every time.