Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Metrics Collector tests #5703

Merged
merged 5 commits into from
Oct 15, 2021

Conversation

gauravIoTEdge
Copy link
Contributor

@gauravIoTEdge gauravIoTEdge commented Oct 15, 2021

This PR adds more tests for verifying the AllowedMetrics filters in the existing Metrics Collector.

Testing Notes

Automated tests

  • New tests added & existing tests pass.

image

Manual testing/verification

  1. Deployed existing IoTEdgeMetricsCollector from Azure Marketplace.
  2. Built new metrics collector with the fix from this PR: Bug fix: Filtering metrics does not work if endpoint is specified. #5665
  3. New deployment ran modules from steps 1&2, for the same set of filters testing the same built-in metrics.
  4. Tested & verified that existing regex/label matching for AllowedMetrics works as expected by looking at the logs for both modules (from steps 1 & 2).

Potential testing limitations

  • Manual tests did not cover multiple/nested device scenarios.
  • However, an effort has been made to emulate such scenarios in the automated tests.

[x] I have read the contribution guidelines.

@gauravIoTEdge gauravIoTEdge marked this pull request as ready for review October 15, 2021 21:28
pmzara
pmzara previously approved these changes Oct 15, 2021
@kodiakhq kodiakhq bot merged commit 8900873 into Azure:release/1.1 Oct 15, 2021
@gauravIoTEdge gauravIoTEdge deleted the More-Azure-Monitor-tests branch October 26, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants