Modify Build Number for New E2E Check-in Pipeline #5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR Re-enables Rust Coverage in Check in Pipelines 1. Remove the Dependency to on nightly build on Rust. Use the same version of rust as other pipelines 2. Use Cargo Tarpaulin for Create Code Coverage Reports. This was recommended by other teams within Microsoft developing rust code. (https://lib.rs/crates/cargo-tarpaulin) 3. Publish HTML Code Coverage Report Based on Coverage Report Note : The Current Code Coverage stands at 44%. I had to reduce the code coverage gate for Rust to 44%. The intent is to increase the code coverage and then increase the gate. Sample Build : https://iotedge.visualstudio.com/iotedge/_build/results?buildId=83180&view=codecoverage-tab
nimanch
changed the title
damonbarry
requested changes
Oct 25, 2021
damonbarry
requested changes
Oct 25, 2021
…om/nimanch/iotedge into personal/nimanch/modifybuildnumber
@damonbarry : Something was messed with my Rust VS Code extension. Fixed it now |
damonbarry
approved these changes
Oct 25, 2021
nimanch
added a commit
to nimanch/iotedge
that referenced
this pull request
Oct 26, 2021
Example Run with this pipeline https://dev.azure.com/msazure/One/_build/results?buildId=48225966&view=results ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. - Description of the pull request includes - [x] concise summary of tests added/modified - [x] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
6 tasks
This was referenced Oct 26, 2021
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
This PR is a manual port of #5717 , #5743 to Enable E2E Check-in Gate for Release/1.1 Branch. Due to the way Images are built (Single Stage vs Multi-stage), Some minor modifications had to be made in creating the build-images.yaml and build-packages.yaml template. Deviation from #5717 1. Use Powershell Scrip in e2e-setup.yaml since windows platform is also used in 1.1 2. Add Debug Log to Print Edge Hub and Edge Agent Image 3. Fix Artifact Filter Pattern (Edgelet artifacts involve both .gz and .deb packages) Testing Done 1. E2E Checkin Gate: https://dev.azure.com/msazure/One/_build/results?buildId=48273899&view=results 2. Build Images Pipeline: https://dev.azure.com/msazure/One/_build/results?buildId=48274103&view=results 3. Build Packages Pipeline: https://dev.azure.com/msazure/One/_build/results?buildId=48274136&view=results 4. CI E2E Test: https://dev.azure.com/msazure/One/_build/results?buildId=48266631&view=logs&j=9ec97737-d75d-57d0-984a-aca7d53a27f6&t=dcdcf879-b5e7-5ee9-8160-60c54b14cdfe ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. - Description of the pull request includes - [x] concise summary of tests added/modified - [x] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
…Pull Requests (#5755) This PR is a manual port of the E2E Check-in Changes made in #5717 #5743 Changes had to be manually ported over due to additional artifacts that get build for Master Branch Deviation from #5717 1. Manually Port Build Images Instead of Cherry Picking since Master images.yaml builds builds more images than Release/1.2 2. Use Master Resources instead of release/1.2 Resources for downloading build artifacts Testing 1. E2E Check-in Test run : https://dev.azure.com/msazure/One/_build/results?buildId=48267053&view=results 2. Build Images Pipeline: https://msazure.visualstudio.com/One/_build/results?buildId=48269740&view=results 3. Build Packages Pipeline: https://msazure.visualstudio.com/One/_build/results?buildId=48269877&view=results 4. CI E2E Test Run: https://dev.azure.com/msazure/One/_build/results?buildId=48272784&view=results ## Azure IoT Edge PR checklist:
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
…Pull Requests (Azure#5755) This PR is a manual port of the E2E Check-in Changes made in Azure#5717 Azure#5743 Changes had to be manually ported over due to additional artifacts that get build for Master Branch Deviation from Azure#5717 1. Manually Port Build Images Instead of Cherry Picking since Master images.yaml builds builds more images than Release/1.2 2. Use Master Resources instead of release/1.2 Resources for downloading build artifacts Testing 1. E2E Check-in Test run : https://dev.azure.com/msazure/One/_build/results?buildId=48267053&view=results 2. Build Images Pipeline: https://msazure.visualstudio.com/One/_build/results?buildId=48269740&view=results 3. Build Packages Pipeline: https://msazure.visualstudio.com/One/_build/results?buildId=48269877&view=results 4. CI E2E Test Run: https://dev.azure.com/msazure/One/_build/results?buildId=48272784&view=results ## Azure IoT Edge PR checklist:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example Run with this pipeline https://dev.azure.com/msazure/One/_build/results?buildId=48225966&view=results
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines
Draft PRs
Draftmode if it is:Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description