E2E: Disable Temp Sensor Test on Windows #5770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and-rewsmith
commented
Nov 2, 2021
| @@ -1,6 +1,7 @@ | |||
| # This E2E test pipeline uses the following filters in order to skip certain tests: | |||
| # Flaky: Flaky on multiple platforms | |||
| # FlakyOnArm: Flaky only on arm | |||
| # FlakyOnWindows: Flaky only on windows | |||
There was a problem hiding this comment.
I forgot to add this to this list in a prior PR
and-rewsmith
changed the title
and-rewsmith
force-pushed
the
andsmi/1.1-debug-windows-pm
branch
from
74779d8
to
5a4be0d
Compare
nimanch
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought we could mitigate this SDK issue in our tests, but it seems worse than previously thought:
Azure/azure-iot-sdk-csharp#2223
We thought ModuleClient would recover on subsequent reconnects, but it never recovers. I have tried fiddling with the delays, removing the explicit
OpenAsync, allowing more reconnect attempts, etc. Nothing seems to stabilize this flakiness. I didn't resort to changing the protocol as I believe our tests should use the default (and I believe most stable) Amqp_Tcp_Only.I feel like the loose thread here for further investigation is the fact that our Longhaul Tests don't suffer from this issue. So it seems like something specific to the TempSensor module might be at play.
For this PR, I have disabled the TempSensor test on windows with a comment to re-enable when the SDK issue is fixed. For the windows 10 minimal suite, I switched to using EdgeAgent ping test.
Waiting on this test run before merge:
https://dev.azure.com/msazure/One/_build/results?buildId=48491714&view=results
5 E2E runs completed successfully
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines
Draft PRs
Draftmode if it is:Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description