Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Re-enable ValidateMetrics on arm and windows #5823

Merged

Conversation

and-rewsmith
Copy link
Contributor

@and-rewsmith and-rewsmith commented Nov 9, 2021

This PR does two things:

  1. Ports Added some extra logging to MetricsValidator module #5799 to release 1.1 branch
  2. Re-enables ValidateMetrics test on arm and windows

Waiting on this e2e test run before merge:
https://dev.azure.com/msazure/One/_build/results?buildId=48990676&view=logs&j=05e63b02-6086-5ea0-db48-4f5aaa2d1eec&t=2bdfacaa-6f5e-56ca-3cd8-6069ffed1dd4

Please replace this line with your PR description and read PR checklist below

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

Draft PRs

  • Open the PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.

Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description

@and-rewsmith and-rewsmith force-pushed the andsmi/1.1-validate-metrics-flaky branch from d6773ee to 80677bd Compare November 10, 2021 21:00
@and-rewsmith and-rewsmith force-pushed the andsmi/1.1-validate-metrics-flaky branch from 80677bd to b4ca1f1 Compare November 10, 2021 21:01
@and-rewsmith and-rewsmith changed the title ValidateMetrics: Investigate why flaky E2E: Re-enable ValidateMetrics on arm and windows Nov 10, 2021
@and-rewsmith and-rewsmith marked this pull request as ready for review November 10, 2021 21:16
@and-rewsmith and-rewsmith merged commit 1dfaef5 into Azure:release/1.1 Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants