Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing moby check #5901

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Conversation

huguesBouvier
Copy link
Contributor

@huguesBouvier huguesBouvier commented Dec 6, 2021

As per discussion with moby team, we are removing the check for moby in iotedge because we won't be able to rely on "+azure" in the version forever.

That check however " if moby_runtime_uri != "npipe://./pipe/iotedge_moby_engine"" is still valid, but only for windows.
So the moby check was removed altogether for linux and just the check if moby_runtime_uri != "npipe://./pipe/iotedge_moby_engine" was kept for windows.

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

Draft PRs

  • Open the PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.

Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description

@huguesBouvier huguesBouvier marked this pull request as ready for review December 7, 2021 01:58
@huguesBouvier huguesBouvier changed the title Removing moby check for non-windows Removing moby check Dec 7, 2021
Copy link
Contributor

@varunpuranik varunpuranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should comment this out for now, instead of removing it.

@arsing
Copy link
Member

arsing commented Dec 7, 2021

I'd rather delete it than comment it out. We can retrieve it from history later if we need it.

@huguesBouvier huguesBouvier merged commit b71b828 into Azure:release/1.1 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants