Remove .NET Core install templates from pipelines #5990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe we can finally remove the .NET Core install templates from our pipelines because either: 1. The pipelines are running on 1ES-hosted agents, which already have the latest version of .NET Core 2.1 and 3.1 installed 2. The pipelines are running on MS-hosted agents, which [already have recent version of .NET Core 2.1 and 3.1 installed](https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu1804-Readme.md#net-core-sdk) This change removes the templates and their references. The templates were installing a hard-coded, much older version of the SDK, and therefore missed the latest security patches and other fixes. I also updated the Functions binding project to replace some deprecated properties that were causing errors when built against the latest .NET Core SDK. Note that this PR does not remove the template that configures the default SDK on Linux. I tested the three pipelines impacted by this change: dotnet checkin, dotnet CI, and images release. ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [X] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [X] Title of the pull request is clear and informative. - [X] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [X] Pull request includes test coverage for the included changes. - Description of the pull request includes - [X] concise summary of tests added/modified - [X] local testing done.
nimanch
approved these changes
Jan 13, 2022
lt72
pushed a commit
to lt72/iotedge
that referenced
this pull request
Jan 31, 2022
Cherry-pick 497108e from release/1.2.
damonbarry
added a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
Cherry-pick 497108e from release/1.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick 497108e from release/1.2.
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines