Remove .NET Core install templates from pipelines #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damonbarry
force-pushed
the
remove-dotnet-install-1.1
branch
from
8a591b1
to
31470a7
Compare
nimanch
approved these changes
Jan 14, 2022
ggjjj
pushed a commit
that referenced
this pull request
May 19, 2022
The changes here are equivalent to 497108e in `release/1.2`, but adapted to 1.1. Specifically, I removed references to install-dotnet*.yaml from Windows pipelines. I also upgraded from 'vs2017-win2016' MS-hosted agents (which are deprecated and will be [removed in March](actions/runner-images#4312)) to our standard 1ES-hosted agents for Windows builds. I tested all impacted checkin and CI pipelines. I did not test the affected release pipelines since they are not currently run from the master branch. This checklist is used to make sure that common guidelines for a pull request are followed. - [X] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [X] Title of the pull request is clear and informative. - [X] Description of the pull request includes a concise summary of the enhancement or bug fix. - [X] Pull request includes test coverage for the included changes. - Description of the pull request includes - [X] concise summary of tests added/modified - [X] local testing done.
ggjjj
pushed a commit
that referenced
this pull request
Jun 1, 2022
The changes here are equivalent to 497108e in `release/1.2`, but adapted to 1.1. Specifically, I removed references to install-dotnet*.yaml from Windows pipelines. I also upgraded from 'vs2017-win2016' MS-hosted agents (which are deprecated and will be [removed in March](actions/runner-images#4312)) to our standard 1ES-hosted agents for Windows builds. I tested all impacted checkin and CI pipelines. I did not test the affected release pipelines since they are not currently run from the master branch. This checklist is used to make sure that common guidelines for a pull request are followed. - [X] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [X] Title of the pull request is clear and informative. - [X] Description of the pull request includes a concise summary of the enhancement or bug fix. - [X] Pull request includes test coverage for the included changes. - Description of the pull request includes - [X] concise summary of tests added/modified - [X] local testing done.
ggjjj
pushed a commit
that referenced
this pull request
Jun 1, 2022
The changes here are equivalent to 497108e in `release/1.2`, but adapted to 1.1. Specifically, I removed references to install-dotnet*.yaml from Windows pipelines. I also upgraded from 'vs2017-win2016' MS-hosted agents (which are deprecated and will be [removed in March](actions/runner-images#4312)) to our standard 1ES-hosted agents for Windows builds. I tested all impacted checkin and CI pipelines. I did not test the affected release pipelines since they are not currently run from the master branch. This checklist is used to make sure that common guidelines for a pull request are followed. - [X] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [X] Title of the pull request is clear and informative. - [X] Description of the pull request includes a concise summary of the enhancement or bug fix. - [X] Pull request includes test coverage for the included changes. - Description of the pull request includes - [X] concise summary of tests added/modified - [X] local testing done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here are equivalent to 497108e in
release/1.2, but adapted to 1.1. Specifically, I removed references to install-dotnet*.yaml from Windows pipelines. I also upgraded from 'vs2017-win2016' MS-hosted agents (which are deprecated and will be removed in March) to our standard 1ES-hosted agents for Windows builds.I tested all impacted checkin and CI pipelines. I did not test the affected release pipelines since they are not currently run from the master branch.
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines