Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contributing.md and modify readme to point to wiki #181

Merged
merged 4 commits into from
Jun 7, 2018

Conversation

kln4dt
Copy link
Contributor

@kln4dt kln4dt commented Jun 6, 2018

No description provided.

@kln4dt kln4dt self-assigned this Jun 6, 2018
@kln4dt kln4dt requested a review from jongio June 6, 2018 22:11
README.md Outdated

Please refer to the [Wiki](https://github.com/Azure/iotedgedev/wiki) for details on setup, usage, and troubleshooting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have the quickstart duplicated here, so it's not just a blank page.

Also include a link to the contributing page.

Also, from the wiki, have a contributing node in the TOC, but point it to the contributing.md doc.

You get some nice stuff on github if you have the contributing.md file https://blog.github.com/2012-09-17-contributing-guidelines/

@kln4dt
Copy link
Contributor Author

kln4dt commented Jun 6, 2018

Will update the TOC once this is merged to avoid pointing to a nonexistent file

README.md Outdated
- It speeds up your inner-loop dev (dev, debug, test) by reducing multi-step build & deploy processes into one-line CLI commands and well as drive your outer-loop CI/CD pipeline. _You can use all the same commands in both stages of your development life-cycle._

## Resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this on bottom of page

README.md Outdated
`iotedgedev docker --setup-registry`

Please see [Azure IoT Edge Dev Resources](https://github.com/jonbgallant/azure-iot-edge-dev) for links to official docs and other IoT Edge dev information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line can be removed.

README.md Outdated
`iotedgedev monitor`

## Overview
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's only do the quickstart, not the overview.

README.md Outdated
1. **Setup Custom Registry**: Use a Custom Container Registry:

`iotedgedev docker --setup-registry`
## Resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When looking at the output html file, I feel like we are using the reader hanging at the end of the Quickstart.

Can you come up with a good way to say something like CLICK HERE TO VIEW ALL DOCS, not that exactly, but something like that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which links to the wiki? in that case, think it would make sense to pull out the reference to the wiki at the beginning of the resources section and have it here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about leaving as-is for now and revisit it later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, will be good to re-read it with some fresher eyes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's still do the link at the top, comment below and call it good.

@@ -4,11 +4,6 @@ The **Azure IoT Edge Dev Tool** greatly simplifies [Azure IoT Edge](https:/azure

- It gets you started with IoT Edge development with the [IoT Edge Dev Container](#iot-edge-dev-container) and IoT Edge Solution Scaffolding that contains a sample module and all the required configuration files.
- It speeds up your inner-loop dev (dev, debug, test) by reducing multi-step build & deploy processes into one-line CLI commands and well as drive your outer-loop CI/CD pipeline. _You can use all the same commands in both stages of your development life-cycle._
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we need a link to the wiki at the top, maybe after the intro. Something like....for full docs see the wiki, link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, that's what I initially had but then coupled it with contributing.md in resources. Want to split that back out or leave the link there and add another reference at the top?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add another at top...just not under resources header...probably in overview section would be best.

@kln4dt kln4dt merged commit 36ec4de into Azure:master Jun 7, 2018
kln4dt added a commit that referenced this pull request Jun 7, 2018
jongio pushed a commit to jongio/iotedgedev that referenced this pull request Jun 12, 2018
* add contributing.md and modify readme to point to wiki

* update readme.md

* remove overview section and move resources to bottom

* add overview section with link to wiki at top
jongio added a commit that referenced this pull request Aug 3, 2018
* Add quickstart video

Add quickstart video

* Search for subscriptions with a lowercased token; fixes #154

* Handle ambiguous or empty subscription results; related #154

* Add prompt to supply more characters when multiple subs are found

* add log level as envvar and testing (#178)

* add contributing.md and modify readme to point to wiki (#181)

* add contributing.md and modify readme to point to wiki

* update readme.md

* remove overview section and move resources to bottom

* add overview section with link to wiki at top

* add Contributing.md content and fix link (#182)

* Add test_azurecli and initial token casing tests

* Fix IoT Hub SKU prompt, changing duplicate S3 to S2

* Update subscription search to support contains for name matches

* Add RUNTIME_LOG_LEVEL to .env.tmp (#186)

* Fix Tests
jongio added a commit that referenced this pull request Aug 3, 2018
)

* Add quickstart video

Add quickstart video

* Search for subscriptions with a lowercased token; fixes #154

* Handle ambiguous or empty subscription results; related #154

* Add prompt to supply more characters when multiple subs are found

* add log level as envvar and testing (#178)

* add contributing.md and modify readme to point to wiki (#181)

* add contributing.md and modify readme to point to wiki

* update readme.md

* remove overview section and move resources to bottom

* add overview section with link to wiki at top

* add Contributing.md content and fix link (#182)

* Add test_azurecli and initial token casing tests

* Fix IoT Hub SKU prompt, changing duplicate S3 to S2

* Update subscription search to support contains for name matches

* Add RUNTIME_LOG_LEVEL to .env.tmp (#186)

* Add envvars clean to work around the py2 unicode in envvar issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants