Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SKU modularization] sku handler interface #357

Merged
merged 8 commits into from
Apr 25, 2024

Conversation

smritidahal653
Copy link
Contributor

Reason for Change:
Adding a CloudSKUHandler interface that will be used to modularize gpu skus across multiple cloud platforms

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:
The cloud specific implementations and fixes/updates to current code will be part of future PRs.

Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we are extending this functionality, I would suggest we place this and sku_config.go in pkg/resources folder. or introducing a new folder like pkg/cloud or pkg/nodes

@Fei-Guo
Copy link
Collaborator

Fei-Guo commented Apr 19, 2024

Now that we are extending this functionality, I would suggest we place this and sku_config.go in pkg/resources folder. or introducing a new folder like pkg/cloud or pkg/nodes

Yes. or just pkg/sku.

@smritidahal653
Copy link
Contributor Author

Now that we are extending this functionality, I would suggest we place this and sku_config.go in pkg/resources folder. or introducing a new folder like pkg/cloud or pkg/nodes

I am going to move cloud_sku_handler.go to pkg/sku. However, I am going to leave sku_config as is right now since the file will be eventually deleted. I will move all implementations of CloudSKUHandler to the same package though.

pkg/sku/cloud_sku_handler.go Outdated Show resolved Hide resolved
pkg/sku/cloud_sku_handler.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants