Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add v1beta1 API for Karpenter #362

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Conversation

helayoty
Copy link
Collaborator

@helayoty helayoty commented Apr 26, 2024

Reason for Change:
This PR is the first of the upcoming work to migrate to use NodeClaim from v1beta1 Karpenter API.

  • Fix lint error in the preset_tuning.go
  • Update metrics in mgr.option in main.go due to updating k8s version to 1.29.3
  • Update Ginkgo version to 1.17.1
  • Add nodeClaim and karpenter nodePool to Kaito clusterrole .

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@helayoty helayoty marked this pull request as draft April 26, 2024 02:19
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 93.19728% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 62.54%. Comparing base (fde6369) to head (1765318).
Report is 13 commits behind head on main.

Files Patch % Lines
pkg/nodeclaim/nodeclaim.go 93.57% 7 Missing and 2 partials ⚠️
pkg/tuning/preset-tuning.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   62.89%   62.54%   -0.35%     
==========================================
  Files          14       27      +13     
  Lines        1307     1901     +594     
==========================================
+ Hits          822     1189     +367     
- Misses        447      650     +203     
- Partials       38       62      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helayoty helayoty marked this pull request as ready for review April 26, 2024 17:41
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty merged commit d9ba35a into main Apr 26, 2024
7 checks passed
@helayoty helayoty deleted the helayoty/karpenter-v1beta1 branch April 26, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants