fix: new artifact streaming containerd configuration and contract #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bryce-Soghigian
changed the base branch from
bsoghigian/artifact-streaming-impl
to
main
Bryce-Soghigian
commented
May 7, 2024
| @@ -384,7 +385,7 @@ var ( | |||
| KubenetTemplate: base64.StdEncoding.EncodeToString(kubenetTemplate), // s | |||
| ContainerdConfigContent: "", // kd | |||
| IsKata: false, // n | |||
|
|
|||
| ArtifactStreamingEnabled: true, // td | |||
There was a problem hiding this comment.
could we also do similar defaulting with cgroupsv2?
There was a problem hiding this comment.
#331 decided yes we can
Pull Request Test Coverage Report for Build 8989077296Details
💛 - Coveralls |
|
closing this in favor of enabling when we have contract |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Adds support for artifact streaming. The change is gated on the ACR Side and karpenter will just enable artifact streaming by default. We want to get this in now so that for GA we have some testing for it.
How was this change tested?
e2e tests
Does this change impact docs?
Release Note