Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate to Go's native multierror handling #354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fmuyassarov
Copy link

Fixes # NA

Description
Now that Go supports handling multiple errors directly from version 1.20 onwards, this commit removes the need for an external library and instead uses native methods of multi-error handling.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


Now that Go supports handling multiple errors directly from version
1.20 onwards, this commit removes the need for an external library
and instead uses native methods of multi-error handling.

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
@fmuyassarov
Copy link
Author

/test

@fmuyassarov
Copy link
Author

@Bryce-Soghigian I assume I don't have permission to trigger tests. Would you mind to help with triggering them?

Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9095892720

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.774%

Totals Coverage Status
Change from base Build 9074172591: 0.0%
Covered Lines: 36279
Relevant Lines: 37105

💛 - Coveralls

@fmuyassarov
Copy link
Author

ping @Bryce-Soghigian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants