Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[library usage] Refine internal token types #379

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Conversation

bcho
Copy link
Member

@bcho bcho commented Dec 18, 2023

This pull request is part of the changes for #373

In this pull request, we

  • refactored the TokenProvider interface to accept context.Context. This allows library user to propagate the context properly. All methods using TokenProvider are being updated as well.
  • exported NewTokenProvider method later library usage.
  • bump gomock to uber go mock version as the original one has been deprecated.

Base automatically changed from internal to master December 20, 2023 01:56
@bcho bcho marked this pull request as ready for review December 20, 2023 02:02
@codecov-commenter
Copy link

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (c6802f6) 64.77% compared to head (9eb41b5) 64.79%.
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/internal/token/interactive.go 0.00% 3 Missing ⚠️
pkg/internal/token/execCredentialPlugin.go 60.00% 2 Missing ⚠️
pkg/internal/token/federatedIdentity.go 0.00% 2 Missing ⚠️
pkg/internal/token/msi.go 0.00% 2 Missing ⚠️
pkg/internal/token/ropc.go 0.00% 2 Missing ⚠️
pkg/internal/token/serviceprincipaltoken_legacy.go 0.00% 2 Missing ⚠️
pkg/internal/token/devicecode.go 50.00% 1 Missing ⚠️
pkg/internal/token/manualtoken.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
+ Coverage   64.77%   64.79%   +0.01%     
==========================================
  Files          23       23              
  Lines        1766     1764       -2     
==========================================
- Hits         1144     1143       -1     
+ Misses        549      548       -1     
  Partials       73       73              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinong weinong merged commit 7564350 into master Dec 20, 2023
5 checks passed
@bcho bcho deleted the internal-token-type branch December 20, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants