Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Azure Developer CLI (azd) as a new login method #398

Merged
merged 6 commits into from Feb 6, 2024

Conversation

wbreza
Copy link
Contributor

@wbreza wbreza commented Jan 19, 2024

Adds support for Azure Developer CLI (azd) to be used as a login method.

When users are deploying AKS based application with azd, the kubeconfig will automatically be converted to use azd authentication when working with clusters with RBAC enabled and local user accounts disabled.

Also updates azidentity package to v1.5.1 to leverage new AzureDeveloperCLICredential

What is Azure Developer CLI

https://aka.ms/azd

Azure Developer CLI (azd) is an open-source tool that accelerates the time it takes for you to get your application from local development environment to Azure. azd provides best practice, developer-friendly commands that map to key stages in your workflow, whether you're working in the terminal, your editor or integrated development environment (IDE), or CI/CD (continuous integration/continuous deployment).

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (4c8a6b2) 65.46% compared to head (47a342e) 64.34%.

Files Patch % Lines
pkg/internal/token/azuredevelopercli.go 20.40% 39 Missing ⚠️
pkg/internal/token/provider.go 0.00% 2 Missing ⚠️
pkg/internal/token/execCredentialPlugin.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   65.46%   64.34%   -1.13%     
==========================================
  Files          27       28       +1     
  Lines        1894     1949      +55     
==========================================
+ Hits         1240     1254      +14     
- Misses        579      620      +41     
  Partials       75       75              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinong weinong merged commit 1dc7e82 into Azure:main Feb 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants