Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Improved error wrapping and add support for object alias #85

Merged
merged 3 commits into from
Mar 12, 2019

Conversation

jon-walton
Copy link
Contributor

@jon-walton jon-walton commented Feb 27, 2019

Hi,

I needed object aliases so this PR adds that. It works the same as described in concept.md. It also adds some improvements to the error wrapping that helped debugging my deployment

I did initially set the k8s config to be keyvaultobjectaliases until I saw concept.md, let me know if you want it renamed.

fixes #51
fixes #66

@msftclas
Copy link

msftclas commented Feb 27, 2019

CLA assistant check
All CLA requirements met.

@ritazh
Copy link
Member

ritazh commented Mar 8, 2019

Thanks for your contribution @jon-walton 🎉 Will review this PR shortly.

@ritazh
Copy link
Member

ritazh commented Mar 11, 2019

I did initially set the k8s config to be keyvaultobjectaliases until I saw concept.md, let me know if you want it renamed.

I think keyvaultobjectaliases is better as it is more consistent with other configs for each key vault object. Let's update this as concept.md is a bit out of date. Thanks @jon-walton!

@jon-walton
Copy link
Contributor Author

thanks @ritazh , I've pushed a new commit containing your feedback

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .NET configuration conventions for structured data Allow to specify an Alias for the file name
3 participants