Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.0 Creates warnings when doing azure/login from a composite action. #409

Open
JasonRSeequent opened this issue Jan 17, 2024 · 7 comments
Assignees
Labels
question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@JasonRSeequent
Copy link

When calling azure/login@v1.6.0 from a composite action, the following warning is generated:

Warning: `pre` execution is not supported for local action from './.github/actions/deploy-infrastructure '

Example workflow block:

      - name: Deploy Infrastructure
        uses: ./.github/actions/deploy-infrastructure
        with:
          azure_credentials: ${{ secrets.AZURE_CREDENTIALS }}

Example action.yaml file:

name: "Deploy Infrastructure"

inputs:
  azure_credentials:
    description: "Azure service principle credentials"
    required: true

runs:
  using: "composite"
  steps:
    - name: Azure login
      uses: azure/login@v1
      with:
        creds: ${{ inputs.azure_credentials}}
@JasonRSeequent JasonRSeequent added the need-to-triage Requires investigation label Jan 17, 2024
@YanaXu YanaXu removed the need-to-triage Requires investigation label Jan 18, 2024
@MoChilia
Copy link
Member

Hi @JasonRSeequent, pre and post steps have not been supported in composite actions yet. This is a highly requested feature, let's track it in actions/runner#1478.

@MoChilia MoChilia added the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Jan 18, 2024
@JasonRSeequent
Copy link
Author

Hi @MoChilia, You are correct that pre and post steps are not currently supported in composite actions, based on the issue you linked, it doesn't look like they will be any time soon.
If azure/login@v1 is supported in composite actions, then surely there should be a workaround to avoid having these warnings appear?
The other workaround is to pin version v1.5.1, which isn't ideal.

@MoChilia
Copy link
Member

@JasonRSeequent, it's a warning message and won't disrupt break your workflow, right? We'll explore ways to enhance this process, but it may not be of high priority. Thank you for your understanding.

@ViktorDronov
Copy link

this is not a high prio but annoying a lot of dev's around the world ;)

@mrvamsidhar-ais
Copy link

Any update on this?

@ViktorDronov
Copy link

any updates on this?

@mrvamsidhar
Copy link

FYI - I end up moving this task to my workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

6 participants