Docker Export/Load #167
Merged
Docker Export/Load #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breanna-Stryker
requested review from
glennmusa,
Phydeauxman and
brooke-hamilton
glennmusa
reviewed
Apr 22, 2021
glennmusa
reviewed
Apr 22, 2021
brooke-hamilton
suggested changes
Apr 22, 2021
There was a problem hiding this comment.
@Breanna-Stryker please create an issue for this PR that has the benefit/result/outcome and the acceptance criteria filled out. This will help understanding of why this PR is being done.
Issue #169 Created. |
brooke-hamilton
approved these changes
Apr 22, 2021
glennmusa
reviewed
Apr 22, 2021
glennmusa
approved these changes
Apr 22, 2021
glennmusa
reviewed
Apr 22, 2021
glennmusa
pushed a commit
that referenced
this pull request
Apr 23, 2021
* Various fixes and refactor to allow for export and load * Update documentation. * Abstract export code to own file, extend to allow file names * Fix various. Co-authored-by: Bree Stryker <bstryker@DESKTOP-3AGKDHF.localdomain>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add export option for docker building
Refactored Docker Build in code order to allow for an exit after a local save
Allow for user to not enter any commands other than docker_strategy=export when exporting
Added sed to dockerfile
Fixed shellcheck recommend on add_auth_scopes.sh
Issue reference
The issue this PR will close: #169
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck.vscode/extensions.json.)