Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for GitHub Actions Deployments #119

Merged
merged 13 commits into from
Dec 21, 2022
Merged

Conversation

sdonohoo
Copy link
Contributor

@sdonohoo sdonohoo commented Dec 20, 2022

  • Fix "location undefined" failure for terraform Prod infra deployment. terraform_st_location was not defined in config-infra-prod.yml
  • Edits to config-infra-prod.yml and config-infra-dev.yml to make available settings and example values consistent.
  • Fix ref check for set-dev-branch and set-prod-branch in tf-gha-deploy-infra.yml. Check failed and all deployments were Dev.
  • Fix incorrect low priority vm value for AmlCompute cluster. 'LowPriority' not valid. Should be 'low_priority'.
  • Remove extra "with:" line from tf-gha-deploy-infra.yml
  • Comment out "on:push" to disable autorun of terraform infra deployment on initial commit before necessary credentials are configured.
  • Duplicate set-env-branch across other workflows to remove hardcoded prod branch config
  • cluster_tier parameter missing from batch compute create
  • deploy training pipeline fails because training dataset doesn't exist. Added register-dataset step and cleaned up unnecessary step dependencies. register-environment/register-dataset/create-compute now run in parallel

@sdonohoo sdonohoo merged commit b12c8ba into Azure:main-dec31 Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant