Feature/cmr addmainentryforymls #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cindyweng
reviewed
Jul 19, 2022
| model_path = os.path.join(args.model_path, run.parent.id) | ||
| explainer_path = os.path.join(args.explainer_path, run.parent.id) | ||
| evaluation_path = os.path.join(args.evaluation_path, run.parent.id) | ||
| prepared_data_path = args.prepared_data_path |
There was a problem hiding this comment.
@chrey-gh This has been updated since you last did a git pull I think. The "run.parent_id" is the newest feature.
There was a problem hiding this comment.
as with the subsequent lines too
cindyweng
reviewed
Jul 19, 2022
| @@ -17,14 +20,14 @@ | |||
|
|
|||
| def parse_args(): | |||
| parser = argparse.ArgumentParser(description="UCI Credit example") | |||
| parser.add_argument("--data_path", type=str, default='data/', help="Directory path to training data") | |||
| parser.add_argument("--uci-credit", type=str, default='data/', help="Directory path to training data") | |||
There was a problem hiding this comment.
again, the main-jul31 version is the latest
cindyweng
reviewed
Jul 19, 2022
| @@ -30,8 +33,8 @@ def main(): | |||
| # Parse command-line arguments | |||
| args = parse_args() | |||
|
|
|||
| prepared_data_path = os.path.join(args.prepared_data_path, run.parent.id) | |||
| model_path = os.path.join(args.model_path, run.parent.id) | |||
| prepared_data_path = args.prepared_data_path | |||
There was a problem hiding this comment.
same here with the run.parent.id thing
cindyweng
reviewed
Jul 19, 2022
classical/python-sdk/config-aml.yml
Outdated
|
|
||
| # Training datasets specification | ||
| # Syntax: <name>:<version>:<mode>:<steps (names separated by +)> | ||
| training_datasets: uci-credit:1:download:prep |
There was a problem hiding this comment.
@mariamedp is the left or the right side of this the correct one?
cindyweng
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR into Azure/mlops-v2
Checklist
I have:
Changes
fixes #