Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Workaround] CNTKModel does not output correct result #1076

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

memoryz
Copy link
Contributor

@memoryz memoryz commented Jun 8, 2021

Workaround for #1075 : CNTKModel does not output correct result for ResNet50 model when running on Databricks.
@mhamilton723 discovered adding a cache call works around the issue.

@memoryz memoryz requested a review from mhamilton723 June 8, 2021 23:03
@welcome
Copy link

welcome bot commented Jun 8, 2021

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. This helps us to create release messages and credit you for your hard work!
Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

Make sure to check out the developer guide for guidance on testing your change.

@memoryz memoryz changed the title Workaround: CNTKModel does not output correct result fix: CNTKModel does not output correct result Jun 8, 2021
@memoryz memoryz changed the title fix: CNTKModel does not output correct result fix: [Workaround] CNTKModel does not output correct result Jun 8, 2021
@memoryz
Copy link
Contributor Author

memoryz commented Jun 8, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #1076 (9f5b024) into master (36ee274) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
- Coverage   84.95%   84.90%   -0.05%     
==========================================
  Files         206      206              
  Lines        9751     9752       +1     
  Branches      550      564      +14     
==========================================
- Hits         8284     8280       -4     
- Misses       1467     1472       +5     
Impacted Files Coverage Δ
.../scala/com/microsoft/ml/spark/cntk/CNTKModel.scala 83.33% <100.00%> (+0.07%) ⬆️
...ala/org/apache/spark/ml/param/DataFrameParam.scala 69.56% <0.00%> (-17.40%) ⬇️
...a/com/microsoft/ml/spark/io/http/HTTPClients.scala 73.33% <0.00%> (-3.34%) ⬇️
...rosoft/ml/spark/stages/PartitionConsolidator.scala 95.74% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ee274...9f5b024. Read the comment docs.

@memoryz
Copy link
Contributor Author

memoryz commented Jun 8, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz
Copy link
Contributor Author

memoryz commented Jun 9, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 0632f1b into microsoft:master Jun 9, 2021
@welcome
Copy link

welcome bot commented Jun 9, 2021

Congrats on merging your first pull request, we appreciate your support! 🎉🎉🎉

@memoryz memoryz deleted the jasowang/iss1075 branch June 9, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants