Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactoring of lightgbm code in preparation for single dataset mode #1088

Merged
merged 1 commit into from Jun 16, 2021

Conversation

imatiach-msft
Copy link
Contributor

sending this PR in preparation for #1066 to reduce the amount of code in other PR. This PR just contains some code refactoring, no changes to functionality.

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #1088 (a88ed84) into master (e7d4eca) will increase coverage by 0.07%.
The diff coverage is 94.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
+ Coverage   84.87%   84.95%   +0.07%     
==========================================
  Files         206      206              
  Lines        9726     9776      +50     
  Branches      552      566      +14     
==========================================
+ Hits         8255     8305      +50     
  Misses       1471     1471              
Impacted Files Coverage Δ
...om/microsoft/ml/spark/io/http/SharedVariable.scala 66.66% <ø> (ø)
...om/microsoft/ml/spark/lightgbm/LightGBMUtils.scala 92.79% <85.18%> (+3.20%) ⬆️
...icrosoft/ml/spark/lightgbm/LightGBMConstants.scala 100.00% <100.00%> (ø)
...a/com/microsoft/ml/spark/lightgbm/TrainUtils.scala 87.53% <100.00%> (+0.03%) ⬆️
...ft/ml/spark/lightgbm/booster/LightGBMBooster.scala 89.70% <100.00%> (+1.84%) ⬆️
...a/com/microsoft/ml/spark/io/http/HTTPClients.scala 73.33% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d4eca...a88ed84. Read the comment docs.

@imatiach-msft imatiach-msft merged commit e8a97ed into microsoft:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants