Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SpeechToTextSDK setLinedService Error #1138

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

xuwq1993
Copy link
Contributor

@xuwq1993 xuwq1993 commented Jul 26, 2021

Error:

SpeechToText didn't support endpoint like: https://wenqxcogserv.cognitiveservices.azure.com/

It only support https://{location}.api,cognitive.microsoft.com/ like: https://eastus.api.cognitive.microsoft.com/

Also, SpeechToText don't support DEP Vnet, therefore, we don't need to consider the PE problems.

@xuwq1993
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #1138 (1d7bc04) into master (87ec5f7) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
- Coverage   85.35%   85.31%   -0.05%     
==========================================
  Files         257      257              
  Lines       12053    12061       +8     
  Branches      629      632       +3     
==========================================
+ Hits        10288    10290       +2     
- Misses       1765     1771       +6     
Impacted Files Coverage Δ
...microsoft/ml/spark/cognitive/SpeechToTextSDK.scala 87.83% <0.00%> (-1.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ec5f7...1d7bc04. Read the comment docs.

@xuwq1993
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make setLinkedService a trait and mix in in both places?

@mhamilton723 mhamilton723 merged commit 4167921 into microsoft:master Jul 26, 2021
@xuwq1993 xuwq1993 deleted the wenqx/fixSpeeckToText branch July 27, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants