-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added two classification examples using Vowpal Wabbit #733
Conversation
chenhuims
commented
Nov 12, 2019
•
edited
Loading
edited
- One example uses Sentiment140 data for twitter sentiment classification
- The other example applies VW algorithm to the adult census dataset
💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. This helps us to create release messages and credit you for your hard work!
Make sure to check out the developer guide for guidance on testing your change. |
notebooks/samples/Classification - Twitter Sentiment with Vowpal Wabbit.ipynb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution! Could you please remove the output cells (esp. ones with images) and resubmit the PR? I'll sign off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your contribution.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
===========================================
+ Coverage 68.56% 80.13% +11.56%
===========================================
Files 230 230
Lines 9197 9197
Branches 504 504
===========================================
+ Hits 6306 7370 +1064
+ Misses 2891 1827 -1064
Continue to review full report at Codecov.
|
Azure Pipelines successfully started running 1 pipeline(s). |
@chenhuims Looks like the data download and load didnt work. your dispay df shows 0 rows. It might have something to do with the schema you provided. Try with inferSchema set to true instead of making and passing a schema. |
Thanks for checking. There was indeed some issue with data downloading. I will try to fix this issue. |
@mhamilton723 I made a fix and the notebook runs without issue on my ADB workspace. However, the E2E test still failed. Could you grant me access to the ADB workspace of the testing pipeline so I can check the detailed logs? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Congrats on merging your first pull request, we appreciate your support! 🎉🎉🎉 |