Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating lightgbm to 2.3.180 #850

Merged
merged 1 commit into from
May 28, 2020

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Apr 3, 2020

Includes performance fixes and minor API changes

This includes a fix for a memory corruption issue:

microsoft/LightGBM#3110

The new release has some major performance optimizations for the parallel distributed learner, training time and especially a major fix for a performance regression during scoring (3-4X):

microsoft/LightGBM#2799

As well as a major fix for allocating more than max int array values per partition:

microsoft/LightGBM#2859

This PR updates to LightGBM 2.3.180 on PR:
microsoft/LightGBM#3110
on commit:
microsoft/LightGBM@8ead7cc

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #850 into master will increase coverage by 2.24%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
+ Coverage   83.18%   85.42%   +2.24%     
==========================================
  Files         187      187              
  Lines        8681     8679       -2     
  Branches      507      525      +18     
==========================================
+ Hits         7221     7414     +193     
+ Misses       1460     1265     -195     
Impacted Files Coverage Δ
...om/microsoft/ml/spark/lightgbm/LightGBMUtils.scala 94.11% <75.00%> (-1.07%) ⬇️
...a/com/microsoft/ml/spark/lightgbm/TrainUtils.scala 90.45% <77.77%> (+2.95%) ⬆️
.../microsoft/ml/spark/lightgbm/LightGBMBooster.scala 87.87% <100.00%> (ø)
.../microsoft/ml/spark/lightgbm/LightGBMDataset.scala 96.00% <100.00%> (-0.16%) ⬇️
...m/microsoft/ml/spark/lightgbm/LightGBMParams.scala 87.29% <0.00%> (+0.55%) ⬆️
...crosoft/ml/spark/lightgbm/LightGBMClassifier.scala 91.08% <0.00%> (+0.99%) ⬆️
.../microsoft/ml/spark/vw/VowpalWabbitRegressor.scala 70.00% <0.00%> (+10.00%) ⬆️
...a/com/microsoft/ml/spark/vw/VowpalWabbitBase.scala 89.04% <0.00%> (+15.06%) ⬆️
...com/microsoft/ml/spark/lightgbm/LightGBMBase.scala 90.62% <0.00%> (+21.87%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb4a45...b315e04. Read the comment docs.

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

currently blocked on this PR:
microsoft/LightGBM#3110

@imatiach-msft
Copy link
Contributor Author

This PR updates to LightGBM 2.3.180 on PR:
microsoft/LightGBM#3110
on commit:
microsoft/LightGBM@8ead7cc

@imatiach-msft imatiach-msft changed the title fix: updating lightgbm to 2.3.170 fix: updating lightgbm to 2.3.180 May 27, 2020
@imatiach-msft imatiach-msft force-pushed the ilmat/lgbm-2.3.160 branch 2 times, most recently from b1b6c06 to 0791a08 Compare May 27, 2020 04:54
@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love seeing tests added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants