Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: categorical parameter regression on dense dataset caused by missing whitespace #909

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

imatiach-msft
Copy link
Contributor

fix for categorical parameter regression on dense dataset caused by missing whitespace

fixes issue #900

@imatiach-msft
Copy link
Contributor Author

/azp run

@imatiach-msft imatiach-msft changed the title fix for categorical parameter regression on dense dataset caused by missing whitespace fix: categorical parameter regression on dense dataset caused by missing whitespace Aug 11, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #909 into master will decrease coverage by 0.71%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   83.92%   83.20%   -0.72%     
==========================================
  Files         189      189              
  Lines        8769     8769              
  Branches      558      558              
==========================================
- Hits         7359     7296      -63     
- Misses       1410     1473      +63     
Impacted Files Coverage Δ
...om/microsoft/ml/spark/lightgbm/LightGBMUtils.scala 95.29% <100.00%> (+3.52%) ⬆️
...crosoft/ml/spark/vw/featurizer/MapFeaturizer.scala 0.00% <0.00%> (-100.00%) ⬇️
...soft/ml/spark/vw/featurizer/StringFeaturizer.scala 0.00% <0.00%> (-100.00%) ⬇️
...oft/ml/spark/vw/featurizer/NumericFeaturizer.scala 0.00% <0.00%> (-100.00%) ⬇️
...ml/spark/vw/featurizer/StringArrayFeaturizer.scala 0.00% <0.00%> (-100.00%) ⬇️
...soft/ml/spark/vw/featurizer/VectorFeaturizer.scala 0.00% <0.00%> (-90.00%) ⬇️
...crosoft/ml/spark/vw/VowpalWabbitInteractions.scala 3.03% <0.00%> (-87.88%) ⬇️
.../microsoft/ml/spark/vw/VowpalWabbitBaseModel.scala 36.58% <0.00%> (-58.54%) ⬇️
...microsoft/ml/spark/vw/VowpalWabbitClassifier.scala 51.51% <0.00%> (-39.40%) ⬇️
...oft/ml/spark/vw/VowpalWabbitMurmurWithPrefix.scala 34.14% <0.00%> (-36.59%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 040ad34...478a9f3. Read the comment docs.

@mhamilton723 mhamilton723 merged commit 95c1f8a into microsoft:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants