Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import-azure-core #247

Merged
merged 3 commits into from May 18, 2022
Merged

import-azure-core #247

merged 3 commits into from May 18, 2022

Conversation

changlong-liu
Copy link
Member

@changlong-liu changlong-liu marked this pull request as ready for review May 5, 2022 06:42
iscai-msft
iscai-msft reviewed May 5, 2022
View reviewed changes
README.rst
@@ -20,6 +20,14 @@ To install:
Release History
---------------

2022-05-05 Version 0.7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test for the serialization and deserialization errors to make sure we're throwing azure.core.exceptions.SerializationError and azure.core.exceptions.DeserializationError?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I see there are many existing testcase around SerializationError/DeserializationError in test_serialization.py. So I added a test to make sure msrest.exceptions.SerializationError is the same one in azure.core.exceptions.
https://github.com/Azure/msrest-for-python/pull/247/files#diff-7f5a7271c4eef44b2f5fda6334ecae0952550de169520dde4a919d86949361c2R2585

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gdsuser1992 , latest msrest get worked with azure-core >=1.24.0.
Would you please make sure the azure-core at /tmp/8da4ea7dc4b7018/antenv/lib/python3.7/site-packages/azure/core/ does be 1.24.0 or 1.24.1?

@lmazuel lmazuel merged commit c97db9d into Azure:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

@iscai-msft iscai-msft iscai-msft approved these changes

@msyyc msyyc msyyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@changlong-liu @lmazuel @iscai-msft @msyyc