test: e2e test #143

JeyJeyGao · 2023-12-20T06:09:33Z

Test:

added e2e test for Linux, windows and macOS
includes 14 test cases: imported pem/pfx certs chain, unordered pem/pfx certs chain, azure key vault csr pem/pfx certs chain, self-signed pem/pfx certs, partial pem/pfx certs chain with local cert bundle and corresponding invalid cases.
the E2E automatically run for PRs from Azure/notation-azure-kv repo and will be skipped for folked repo

Additional files:

dockerfile for build distribution registry on windows
zot configuration for local registry on macOS
generate-certs.sh script for create certificate on azure key vault for future re-generating certificates.

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

codecov · 2023-12-20T06:11:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8884168) 95.09% compared to head (db7088c) 91.65%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   95.09%   91.65%   -3.45%     
==========================================
  Files          16       16              
  Lines         551      551              
  Branches        0       67      +67     
==========================================
- Hits          524      505      -19     
- Misses         27       33       +6     
- Partials        0       13      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

shizhMSFT

Should .github/e2e/ be put at tests/e2e/?

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao · 2023-12-22T01:03:22Z

Should .github/e2e/ be put at tests/e2e/

@shizhMSFT Updated.

.github/workflows/test.yml

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

shizhMSFT

LGTM

commit e3fce3d Author: Junjie Gao <junjiegao@microsoft.com> Date: Fri Dec 22 12:11:33 2023 +0800 test: e2e test (#143) Test: - added e2e test for Linux, windows and macOS - includes 14 test cases: imported pem/pfx certs chain, unordered pem/pfx certs chain, azure key vault csr pem/pfx certs chain, self-signed pem/pfx certs, partial pem/pfx certs chain with local cert bundle and corresponding invalid cases. - the E2E automatically run for PRs from `Azure/notation-azure-kv` repo and will be skipped for folked repo Additional files: - dockerfile for build distribution registry on windows - zot configuration for local registry on macOS - generate-certs.sh script for create certificate on azure key vault for future re-generating certificates. --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit e3fce3d Author: Junjie Gao <junjiegao@microsoft.com> Date: Fri Dec 22 12:11:33 2023 +0800 test: e2e test (#143) Test: - added e2e test for Linux, windows and macOS - includes 14 test cases: imported pem/pfx certs chain, unordered pem/pfx certs chain, azure key vault csr pem/pfx certs chain, self-signed pem/pfx certs, partial pem/pfx certs chain with local cert bundle and corresponding invalid cases. - the E2E automatically run for PRs from `Azure/notation-azure-kv` repo and will be skipped for folked repo Additional files: - dockerfile for build distribution registry on windows - zot configuration for local registry on macOS - generate-certs.sh script for create certificate on azure key vault for future re-generating certificates. --------- Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao added 30 commits November 20, 2023 16:53

feat: add a script for generating certs for E2E

c6ff3be

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

test: add e2e server for downloading artifacts

8be1da9

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update files position

9e8fd48

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update files

1dc4899

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

test: add test case

450fedb

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update test

da55332

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update test case

404438d

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update test case

31e6265

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: add az login

45fd80c

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update trigger for test workflow

dcfa8f6

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update ci

7ec56aa

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: add test cases

a657a18

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

test: add windows

d3e6f26

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update

298f3d1

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update script

c331022

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update code

d85b00c

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update e2e pipline

352b8b3

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update

f7b5e11

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update code

c733071

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update

a6a853d

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update

b39380f

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update

1d90ef9

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update

47de3a9

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update

70fd228

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update

cc47392

fix: update

55620d9

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update

e64bdce

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update script and add test cases

28e2d2f

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update code

b1cb2ef

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: updte test

4a175a4

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao added 6 commits November 27, 2023 11:25

fix: update test

2a4e52d

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update test

4134e2e

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update test

7e85a9a

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

test: add test cases

e19ded2

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update step name for unit test

a98fde7

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update pipeline

5130ec4

JeyJeyGao added the safe to test label Dec 20, 2023

JeyJeyGao removed the safe to test label Dec 20, 2023

fix: update pipeline

8091c51

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao added the safe to test label Dec 20, 2023

JeyJeyGao added 2 commits December 20, 2023 14:37

fix: update

85d88e2

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update

91eacf5

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao removed the safe to test label Dec 20, 2023

fix: update description

7cc0319

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

JeyJeyGao requested a review from shizhMSFT December 20, 2023 07:07

JeyJeyGao self-assigned this Dec 20, 2023

shizhMSFT reviewed Dec 21, 2023

View reviewed changes

JeyJeyGao added 2 commits December 22, 2023 08:43

fix: update e2e folder

04c201c

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update certs directory

e629850

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

shizhMSFT reviewed Dec 22, 2023

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

JeyJeyGao added 2 commits December 22, 2023 11:28

fix: update download server

752ba4a

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

fix: update code

db7088c

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

shizhMSFT approved these changes Dec 22, 2023

View reviewed changes

JeyJeyGao merged commit e3fce3d into main Dec 22, 2023
12 checks passed

JeyJeyGao deleted the test/e2e branch December 22, 2023 04:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: e2e test #143

test: e2e test #143

JeyJeyGao commented Dec 20, 2023 •

edited

Loading

codecov bot commented Dec 20, 2023 •

edited

Loading

shizhMSFT left a comment

JeyJeyGao commented Dec 22, 2023

shizhMSFT left a comment

test: e2e test #143

test: e2e test #143

Conversation

JeyJeyGao commented Dec 20, 2023 • edited Loading

codecov bot commented Dec 20, 2023 • edited Loading

Codecov Report

shizhMSFT left a comment

Choose a reason for hiding this comment

JeyJeyGao commented Dec 22, 2023

shizhMSFT left a comment

Choose a reason for hiding this comment

JeyJeyGao commented Dec 20, 2023 •

edited

Loading

codecov bot commented Dec 20, 2023 •

edited

Loading