Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for RequestFailedException #153

Merged
merged 5 commits into from Jan 30, 2024
Merged

Conversation

JeyJeyGao
Copy link
Collaborator

Signed-off-by: Junjie Gao junjiegao@microsoft.com

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e1442cd) 91.65% compared to head (f07210c) 91.22%.
Report is 1 commits behind head on main.

Files Patch % Lines
Notation.Plugin.AzureKeyVault/Program.cs 83.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   91.65%   91.22%   -0.43%     
==========================================
  Files          16       16              
  Lines         551      581      +30     
  Branches       67       72       +5     
==========================================
+ Hits          505      530      +25     
- Misses         33       38       +5     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
Copy link
Collaborator Author

Added lines #L20 - L24 were not covered by tests

We cannot cover those lines because it's in Main() and cannot be mocked.

Copy link
Member

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 1d44efe into main Jan 30, 2024
13 checks passed
@shizhMSFT shizhMSFT deleted the test/azure_exception branch April 12, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants