Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor for unit test #97

Merged
merged 20 commits into from May 5, 2023
Merged

Conversation

JeyJeyGao
Copy link
Collaborator

Refactor:

  • refactor IPluginCommand to support dependency injection for unit test
  • refactor KeyVaultClient to implement IKeyVaultClient for unit test

Test:

  • added unit test cases

Signed-off-by: Junjie Gao junjiegao@microsoft.com

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #97 (08f6945) into main (5178df8) will increase coverage by 77.01%.
The diff coverage is 89.74%.

@@            Coverage Diff             @@
##            main      #97       +/-   ##
==========================================
+ Coverage   7.29%   84.30%   +77.01%     
==========================================
  Files         15       15               
  Lines        425      446       +21     
==========================================
+ Hits          31      376      +345     
+ Misses       394       70      -324     
Impacted Files Coverage Δ
....Plugin.AzureKeyVault/Command/GetPluginMetadata.cs 100.00% <ø> (ø)
Notation.Plugin.AzureKeyVault/Program.cs 0.00% <0.00%> (ø)
Notation.Plugin.AzureKeyVault/Protocol/KeySpec.cs 95.34% <ø> (+95.34%) ⬆️
...tation.Plugin.AzureKeyVault/Command/DescribeKey.cs 100.00% <100.00%> (+100.00%) ⬆️
....Plugin.AzureKeyVault/Command/GenerateSignature.cs 100.00% <100.00%> (+100.00%) ⬆️
...on.Plugin.AzureKeyVault/KeyVault/KeyVaultClient.cs 92.00% <100.00%> (+92.00%) ⬆️

... and 8 files with indirect coverage changes

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Member

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Member

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 07cd835 into Azure:main May 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants