Skip to content

Commit

Permalink
Nitishm/bug/344/finalizer check (#346)
Browse files Browse the repository at this point in the history
* Fix finalizer check

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>

* Another fix to reverse

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
  • Loading branch information
nitishm committed Jun 22, 2021
1 parent 96a8d85 commit 49631d9
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkg/helpers/reconcile.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import (
"context"
"errors"
"fmt"
"os"

"github.com/Azure/Orkestra/api/v1alpha1"
"github.com/Azure/Orkestra/pkg/meta"
"github.com/Azure/Orkestra/pkg/registry"
Expand All @@ -13,7 +15,6 @@ import (
"github.com/go-logr/logr"
"github.com/jinzhu/copier"
"helm.sh/helm/v3/pkg/chart"
"os"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
Expand Down Expand Up @@ -110,7 +111,7 @@ func (helper *ReconcileHelper) Reverse(ctx context.Context) (ctrl.Result, error)
} else if isSucceeded {
return ctrl.Result{}, nil
}
return ctrl.Result{RequeueAfter: v1alpha1.DefaultProgressingRequeue}, nil
return ctrl.Result{Requeue: true, RequeueAfter: v1alpha1.DefaultProgressingRequeue}, nil
}

func (helper *ReconcileHelper) reconcileApplications() error {
Expand Down

0 comments on commit 49631d9

Please sign in to comment.