Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Helm Controller Structs into the AppGroup Spec #255

Merged
merged 2 commits into from
May 19, 2021

Conversation

jonathan-innis
Copy link
Contributor

Closes #251

@codecov-commenter
Copy link

Codecov Report

Merging #255 (2e4c2f1) into main (429d372) will increase coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   30.89%   31.31%   +0.42%     
==========================================
  Files           5        5              
  Lines        1039     1025      -14     
==========================================
  Hits          321      321              
+ Misses        690      676      -14     
  Partials       28       28              
Impacted Files Coverage Δ
pkg/workflow/argo.go 1.78% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429d372...2e4c2f1. Read the comment docs.

Copy link
Contributor

@nitishm nitishm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nitishm nitishm merged commit 683fc3f into Azure:main May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed helm-controller's HelmRelease struct into ApplicationSpec.Release of the ApplicationGroup CRD
3 participants