Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Argo v3.0.7 #318

Merged
merged 6 commits into from
Jun 14, 2021
Merged

Upgrade to Argo v3.0.7 #318

merged 6 commits into from
Jun 14, 2021

Conversation

mahalrs
Copy link
Contributor

@mahalrs mahalrs commented Jun 14, 2021

Closes #185

Upgraded to Argo v3.0.7

@mahalrs mahalrs marked this pull request as ready for review June 14, 2021 08:50
@nitishm
Copy link
Contributor

nitishm commented Jun 14, 2021

Can you add a commit to update the docs as well (operators section) with the new values from the chart

@codecov-commenter
Copy link

Codecov Report

Merging #318 (b3620c8) into main (0b4357b) will increase coverage by 4.90%.
The diff coverage is 24.74%.

❗ Current head b3620c8 differs from pull request most recent head 1171a0a. Consider uploading reports for the commit 1171a0a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   18.33%   23.24%   +4.90%     
==========================================
  Files           5       12       +7     
  Lines         807      783      -24     
==========================================
+ Hits          148      182      +34     
+ Misses        624      594      -30     
+ Partials       35        7      -28     
Impacted Files Coverage Δ
pkg/utils/helm.go 0.00% <ø> (ø)
pkg/utils/probe.go 0.00% <0.00%> (ø)
pkg/workflow/executor.go 0.00% <0.00%> (ø)
pkg/workflow/graph.go 0.00% <0.00%> (ø)
pkg/workflow/utils.go 0.00% <0.00%> (ø)
pkg/workflow/workflow.go 0.00% <0.00%> (ø)
pkg/workflow/workflow_reverse.go 0.00% <0.00%> (ø)
pkg/workflow/workflow_forward.go 2.90% <2.90%> (ø)
pkg/utils/helpers.go 39.47% <39.47%> (ø)
controllers/appgroup_controller.go 64.38% <62.50%> (+34.38%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb06dd...1171a0a. Read the comment docs.

@mahalrs
Copy link
Contributor Author

mahalrs commented Jun 14, 2021

Can you add a commit to update the docs as well (operators section) with the new values from the chart

Done

Copy link
Contributor

@nitishm nitishm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nitishm nitishm merged commit 47d8dc3 into Azure:main Jun 14, 2021
@mahalrs mahalrs deleted the argo3x branch June 16, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Argo v3.0.x
3 participants