Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slack button #329

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Add slack button #329

merged 3 commits into from
Jun 15, 2021

Conversation

nitishm
Copy link
Contributor

@nitishm nitishm commented Jun 15, 2021

Signed-off-by: Nitish Malhotra nitish.malhotra@gmail.com

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
docs/index.md Outdated

[![Slack](https://img.shields.io/badge/slack-slack-brightgreen)](https://join.slack.com/t/azureorkestra/shared_invite/zt-rowzrite-Hm_eaih4GyjjZXWftuoqPQ)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way to add this so it isn't just a button? I feel like buttons are traditionally for code-related things and this is for community engagement

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have good examples of how other projects do this @helayoty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this might be a better way - https://github.com/openservicemesh/osm#community

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nitishm nitishm merged commit ddfd626 into Azure:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants