Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeepCopy for Executor Node #396

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Oct 5, 2021

  • Fixes DeepCopy not copying over the dependencies and params
  • Fixes DeepCopy not actual deepcopying the slices

@codecov-commenter
Copy link

Codecov Report

Merging #396 (f0d204a) into main (afc0de0) will increase coverage by 0.47%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   69.35%   69.82%   +0.47%     
==========================================
  Files           9        9              
  Lines         509      517       +8     
==========================================
+ Hits          353      361       +8     
  Misses        134      134              
  Partials       22       22              
Impacted Files Coverage Δ
pkg/graph/graph.go 87.68% <95.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc0de0...f0d204a. Read the comment docs.

Copy link
Contributor

@nitishm nitishm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 6af0807 into Azure:main Oct 5, 2021
@jonathan-innis jonathan-innis deleted the joinnis/fix-deepcopy branch October 5, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants