Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow generator for custom executor #406

Conversation

nitishm
Copy link
Contributor

@nitishm nitishm commented Nov 5, 2021

Closes #401

Signed-off-by: Nitish Malhotra nitish.malhotra@gmail.com

Closes Azure#401

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #406 (eb83fc4) into main (86b28c0) will increase coverage by 0.58%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   69.82%   70.40%   +0.58%     
==========================================
  Files           9        9              
  Lines         517      517              
==========================================
+ Hits          361      364       +3     
+ Misses        134      132       -2     
+ Partials       22       21       -1     
Impacted Files Coverage Δ
pkg/graph/graph.go 87.68% <50.00%> (ø)
controllers/workflow_status_controller.go 69.53% <0.00%> (+2.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b28c0...eb83fc4. Read the comment docs.

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
@nitishm
Copy link
Contributor Author

nitishm commented Nov 5, 2021

/cc @vineetgarhewal

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nitishm nitishm merged commit 12d0f46 into Azure:main Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing forward for Executor "custom" type
3 participants