Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: media type enum & failing media + app tests #206

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

kevinhillinger
Copy link
Member

@kevinhillinger kevinhillinger commented Jun 19, 2023

Description

  • video test still failing. Commented out and isolated the test for video for further correction
  • logo large was "LargeLarge" for example and was causing test failure for image support, causing a regression
  • media add command still returning None in the case where the other image-type enum values were not being checked
  • Managed Application and Solution Template tests failing due to timing and test structure issues.

Resolutions

  • scenario tests for solution template and managed app now pass
  • The media enum and "image type" add no longer cause a regression in scenario tests covering large logo image
  • recorded new set of tests

…dn't match what was required. Passing tests.
@kevinhillinger kevinhillinger merged commit 5a1744c into main Jun 19, 2023
2 of 3 checks passed
@kevinhillinger kevinhillinger deleted the kevinhillinger/205 branch January 11, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: failing scenario test for managed application Fix: failing scenario test in media subcommand
2 participants