-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport layer for proxy handshake #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SreeramGarlapati
requested review from
timtay-microsoft and
prmathur-microsoft
September 12, 2018 23:13
zolvarga
reviewed
Sep 13, 2018
src/main/java/com/microsoft/azure/proton/transport/ws/impl/WebSocketImpl.java
Show resolved
Hide resolved
zolvarga
reviewed
Sep 13, 2018
src/main/java/com/microsoft/azure/proton/transport/proxy/impl/ProxyImpl.java
Show resolved
Hide resolved
zolvarga
approved these changes
Sep 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timtay-microsoft
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gemmellr @tabish121 - truly appreciate - if you can review this.
cc: @timtay-microsoft @apraovjr @jongio @JamesBirdsall @binzywu @yvgopal @ShubhaVijayasarathy @tameraw @prmathur-microsoft @jasmineymlo @nemakam
Tracking Issue.