-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use managed identity for SQL #378
Conversation
cbef281
to
8ecf26f
Compare
@@ -22,6 +22,9 @@ type DeploymentSettings = { | |||
@description('The ID of the principal that is being used to deploy resources.') | |||
principalId: string | |||
|
|||
@description('The name of the principal that is being used to deploy resources.') | |||
principalName: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be the time to switch over to includes for types. See https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/bicep-import
Since you are touching DeploymentSettings everywhere, mark the type here with @export(), then swap out the type definitions everywhere else with an import statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, although I believe we're using an older version of bicep that doesn't suppor this. I plan on updating this so we don't have to deal with this in the future
This removes the SQL admin password and just uses Entra for all logins. The developer is added as an owner so they can bootstrap the application and docs around adding the user have been removed.
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2027162