Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Chart should allow specifying a custom volume mount to support Custom Azure Environments #444

Closed
chrisamert opened this issue Mar 15, 2021 · 1 comment · Fixed by #451
Closed

Helm Chart should allow specifying a custom volume mount to support Custom Azure Environments #444

chrisamert opened this issue Mar 15, 2021 · 1 comment · Fixed by #451
Assignees
@chrisamert
Labels
enhancement New feature or request

Comments

@chrisamert
Copy link
Contributor

Describe the solution you'd like
The documentation page here: https://azure.github.io/secrets-store-csi-driver-provider-azure/configurations/custom-environments/ describes the process to get the AKV Provider working in Custom Azure Environments. One of these steps is to mount a file from the Kubernetes host node into the AKV Provider Pods. However the Helm Charts currently don't have any options to specify these Volume mounts, and the file we need isn't currently mounted onto the Pod.

The solution I propose is to add a new section to the Helm Chart to allow a custom path be mounted on the AKV Provider Pods. Doing that will enable the Helm Chart be used in these Custom Azure Environments. I'd be happy to submit a PR with this change.
@chrisamert chrisamert added the enhancement New feature or request label Mar 15, 2021
@aramase
Copy link
Member

aramase commented Mar 16, 2021

That makes sense! @chrisamert Please feel free to open a PR. We can review and get it merged.

@aramase aramase added this to the 0.0.14 milestone Mar 16, 2021
chrisamert added a commit to chrisamert/secrets-store-csi-driver-provider-azure that referenced this issue Mar 17, 2021
@chrisamert
Add Helm Chart variables to mount the Custom Azure Environment File
25491d2 
To get the Azure KeyVault Provider working in air-gapped or on-prem Azure clouds, the Custom Azure Environment file needs to be mounted on the KeyVault Provider pods.  This change adds new variables to the Helm chart that allows this Volume Mount to be created.

Fixes Azure#444
@chrisamert chrisamert mentioned this issue Mar 17, 2021
Merged
5 tasks
chrisamert added a commit to chrisamert/secrets-store-csi-driver-provider-azure that referenced this issue Apr 2, 2021
@chrisamert
Add Helm Chart variables to mount the Custom Azure Environment File
bd59c13 
To get the Azure KeyVault Provider working in air-gapped or on-prem Azure clouds, the Custom Azure Environment file needs to be mounted on the KeyVault Provider pods.  This change adds new variables to the Helm chart that allows this Volume Mount to be created.

Fixes Azure#444
@aramase aramase removed this from the 0.0.14 milestone Apr 5, 2021
chrisamert added a commit to chrisamert/secrets-store-csi-driver-provider-azure that referenced this issue Apr 5, 2021
@chrisamert
Add Helm Chart variables to mount the Custom Azure Environment File
27e7f7c 
To get the Azure KeyVault Provider working in air-gapped or on-prem Azure clouds, the Custom Azure Environment file needs to be mounted on the KeyVault Provider pods.  This change adds new variables to the Helm chart that allows this Volume Mount to be created.

Fixes Azure#444
aramase pushed a commit that referenced this issue Apr 6, 2021
@chrisamert
Add Helm Chart variables to mount the Custom Azure Environment File (#…
32c3d68 
…451)

To get the Azure KeyVault Provider working in air-gapped or on-prem Azure clouds, the Custom Azure Environment file needs to be mounted on the KeyVault Provider pods.  This change adds new variables to the Helm chart that allows this Volume Mount to be created.

Fixes #444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisamert chrisamert

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@aramase @chrisamert