Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Run the provider with the minimum number of permissions required. #967

Closed
pierluigilenoci opened this issue Aug 31, 2022 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@pierluigilenoci
Copy link
Contributor

pierluigilenoci commented Aug 31, 2022

Describe the solution you'd like

PR #966 (Issue #787) is a workaround to get the software to work on K8s v1.25.
In this way, it doesn't run with the necessary restricted permissions.

All these "permissions" need to be moved into the securityContexts at the pod/container level.

Ref: https://github.com/Azure/secrets-store-csi-driver-provider-azure/blob/master/charts/csi-secrets-store-provider-azure/templates/podsecuritypolicy.yaml#L8-L23

[A clear and concise description of what you want to happen.]

I would like the software to run with the minimum number of permissions it needs to run.

One solution would be to put the privileged values in the chart as default.
And the more restrictive values as a comment (to make configuration easier).
Or allow the choice between the two options via the linux.privileged value.

Anything else you would like to add:

Nothing to add other than a big thank you to the maintainers.

Environment:

  • Secrets Store CSI Driver version: Not relevant
  • Azure Key Vault provider version: Not relevant
  • Kubernetes version: 1.25.*
  • Cluster type: Not relevant
@pierluigilenoci pierluigilenoci added the enhancement New feature or request label Aug 31, 2022
@pierluigilenoci
Copy link
Contributor Author

@aramase could you please take a look?

@graemerobertson graemerobertson mentioned this issue Dec 7, 2022
5 tasks
@sozercan
Copy link
Member

sozercan commented Jan 5, 2023

@pierluigilenoci these helm configurations already exist https://github.com/Azure/secrets-store-csi-driver-provider-azure/blob/master/charts/csi-secrets-store-provider-azure/templates/provider-azure-installer.yaml#L79-L90

is there anything else you are looking for? if not, are we okay to close this issue?

@pierluigilenoci
Copy link
Contributor Author

@sozercan if the permissions included in the chart are the minimum number for the provider to work, I'm satisfied.

@aramase aramase closed this as completed Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants