Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove psp #966

Merged
merged 1 commit into from Aug 31, 2022
Merged

chore: remove psp #966

merged 1 commit into from Aug 31, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Aug 30, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Removes deprecated psp

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #787

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #966 (8428b3b) into master (8e839e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #966   +/-   ##
=======================================
  Coverage   59.18%   59.18%           
=======================================
  Files          10       10           
  Lines        1061     1061           
=======================================
  Hits          628      628           
  Misses        398      398           
  Partials       35       35           

@aramase aramase marked this pull request as ready for review August 30, 2022 22:13
@aramase aramase requested a review from nilekhc as a code owner August 30, 2022 22:13
@aramase
Copy link
Member Author

aramase commented Aug 30, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@graemerobertson
Copy link

@aramase do you know if there are any plans to release with these changes any time soon? These changes aren't in the latest version (1.3.0) and as a result we're not currently able to install on the latest Kubernetes version (1.25) which removes support for PodSecurityPolicys. Thanks!

@aramase
Copy link
Member Author

aramase commented Dec 6, 2022

@aramase do you know if there are any plans to release with these changes any time soon? These changes aren't in the latest version (1.3.0) and as a result we're not currently able to install on the latest Kubernetes version (1.25) which removes support for PodSecurityPolicys. Thanks!

@graemerobertson The charts will be released this week. Pod Security Policy is only installed when rbac.pspEnabled=true. You should be able to install the helm charts without that flag which is default false.

@graemerobertson
Copy link

Thank you!

@graemerobertson
Copy link

Out of interest, are there any plans to resolve #967? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
4 participants