feat: support splitting certs and private key #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
==========================================
+ Coverage 58.91% 59.08% +0.17%
==========================================
Files 10 10
Lines 1066 1095 +29
==========================================
+ Hits 628 647 +19
- Misses 403 413 +10
Partials 35 35 |
aramase
force-pushed
the
aramase/issue-933
branch
5 times, most recently
from
8adeaac
to
9a846a9
Compare
aramase
commented
Nov 2, 2022
aramase
commented
Nov 2, 2022
| @@ -46,6 +45,10 @@ var ( | |||
|
|
|||
| metricsBackend = flag.String("metrics-backend", "Prometheus", "Backend used for metrics") | |||
| prometheusPort = flag.Int("prometheus-port", 8898, "Prometheus port for metrics backend") | |||
|
|
|||
| constructPEMChain = flag.Bool("construct-pem-chain", true, "explicitly reconstruct the pem chain in the order: SERVER, INTERMEDIATE, ROOT") | |||
| writeCertAndKeyInSeparateFiles = flag.Bool("write-cert-and-key-in-separate-files", false, | |||
There was a problem hiding this comment.
I'm not a big fan of the long flag name but it's descriptive. I'm open to suggestions on this one.
aramase
force-pushed
the
aramase/issue-933
branch
from
9a846a9
to
9079925
Compare
nilekhc
reviewed
Nov 21, 2022
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
force-pushed
the
aramase/issue-933
branch
from
9079925
to
639014f
Compare
nilekhc
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
Reason for Change:
Requirements
Issue Fixed:
fixes #933
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: