New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enables docker ecosystem for dependabot #1014
Conversation
e140eb4
to
cd0aa11
Compare
.github/dependabot.yml
Outdated
@@ -12,3 +12,9 @@ updates: | |||
interval: "weekly" | |||
commit-message: | |||
prefix: "chore" | |||
- package-ecosystem: "docker" | |||
directory: "/manifest_staging" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm playing around with this on a local fork to see how it works...
Unfortunately, I realized the check isn't recursive, so you'll need to manually specify the actual directory containing the chart... I filed dependabot/dependabot-core#6047 for us to evaluate changing that behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And looks like there's another bug, even when you do get it configured correctly: dependabot/dependabot-core#6048
I'll try to debug ☝️ tomorrow.
I enabled the Once I get dependabot/dependabot-core#6048 fixed, hopefully it will start working and opening PR's for you. |
Also, thanks again @nilekhc for offering this repo as a test case, even for using in my own fork it's been great to have much more realistic data for testing than anything I'd put together quickly. |
@jeffwidman Do you still want me to update the path and point it to the |
We are happy to help! 🙂 |
@jeffwidman Any word on this? |
Yes, please do point the path at the Beyond that, I figured out why it wasn't working on my fork of your repo, and fixed some other bugs along the way:
Once the last one is merged/deployed, this should all start working... but we have an internal deploy freeze because of GitHub Universe so I won't be able to deploy til late tomorrow or Friday. |
cd0aa11
to
2a9fc3f
Compare
All the PR's have been merged, and this now works correctly on my fork... once you merge, can you confirm it works correctly here as well? You should get a PR opened by Dependabot similar to the ones here: https://github.com/jeffwidman/secrets-store-csi-driver-provider-azure/pulls |
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
2a9fc3f
to
f859283
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com
Reason for Change:
Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: